Skip to content

DAOS-19361 test: update ftest/cart to use self.log.info - #18720

Merged
daltonbohning merged 4 commits into
masterfrom
dbohning/daos-19361
Aug 4, 2026
Merged

DAOS-19361 test: update ftest/cart to use self.log.info#18720
daltonbohning merged 4 commits into
masterfrom
dbohning/daos-19361

Conversation

@daltonbohning

@daltonbohning daltonbohning commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Update ftest/cart tests to use self.log.info instead of print so logging goes to the log instead of stdout.

Test-tag: cart
Skip-unit-tests: true
Skip-fault-injection-test: true

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@daltonbohning daltonbohning self-assigned this Jul 24, 2026
@daltonbohning daltonbohning changed the title DAOS-19361 test: update cart test to use self.log.info DAOS-19361 test: update cart tests to use self.log.info Jul 24, 2026
@github-actions

Copy link
Copy Markdown

Ticket title is 'ftest: update cart tests to use self.log'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-19361

@daltonbohning daltonbohning changed the title DAOS-19361 test: update cart tests to use self.log.info DAOS-19361 test: update ftest/cart to use self.log.info Jul 24, 2026
@daltonbohning
daltonbohning force-pushed the dbohning/daos-19361 branch 2 times, most recently from 4a4d55c to 71851b5 Compare July 24, 2026 21:25
@daosbuild3

Copy link
Copy Markdown
Collaborator

@daltonbohning
daltonbohning force-pushed the dbohning/daos-19361 branch 2 times, most recently from 5f98399 to 4117963 Compare July 28, 2026 21:41
@daosbuild3

Copy link
Copy Markdown
Collaborator

Update ftest/cart tests to use self.log.info instead of print
so logging goes to the log instead of stdout.

Test-tag: cart
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
@daosbuild3

Copy link
Copy Markdown
Collaborator

ctl_five_node.py keeps timing out in launch_test so remove the
subprocess.PIPE wrapper.
This can be investigated later.

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional Cluster Box Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18720/7/execution/node/1140/log

@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18720/7/execution/node/1326/log

Test-tag: cart
Skip-unit-tests: true
Skip-fault-injection-test: true
@daltonbohning
daltonbohning marked this pull request as ready for review July 31, 2026 14:57
@daltonbohning
daltonbohning requested review from a team as code owners July 31, 2026 14:57
@daltonbohning
daltonbohning requested a review from phender July 31, 2026 14:57
"unresolved.\n".format(glob_pat))
self.log.info("Didn't find completion file(s): '%s'.", glob_pat)
self.log.info("This indicates not all CaRT binaries exited gracefully.")
self.log.info("Marking test pass while DAOS-7892 remains unresolved.")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://daosio.atlassian.net/browse/DAOS-7892 is resolved with a merged fix. Maybe this should be an error.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Done

Comment thread src/tests/ftest/cart/util/cart_utils.py Outdated
else:
print("WARNING: I didn't find the daos tests directory. "
+ "No test directories have been added to your PATH..\n")
self.log.info("WARNING: I didn't find the daos tests directory. "

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use self.log.warn() here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Done

Test-tag: cart
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
@daltonbohning
daltonbohning requested a review from phender August 3, 2026 17:12
@daltonbohning
daltonbohning requested a review from a team August 4, 2026 14:07
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 4, 2026
@daltonbohning
daltonbohning merged commit 70332fd into master Aug 4, 2026
29 checks passed
@daltonbohning
daltonbohning deleted the dbohning/daos-19361 branch August 4, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Development

Successfully merging this pull request may close these issues.

4 participants